Sema: Reexport SPI via Swift exported imports but not clang's #70566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules Exported imports are common between clang modules. Make sure we test against accidently reexporting Swift SPIs through these exported imports.
xymus
requested review from
artemcm,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
xymus
force-pushed
the
spi-reexport-swift-only
branch
from
652677c to
c7e90ca
Compare
…imports This is a new attempt at a reexport feature for SPI decls. The previous behavior was to reexport SPIs only between modules with both `@_exported` and an export-as relationship. The limitation on export-as turned out to be too restrictive in some cases. We may be tempted to reexport SPIs through all exported imports. However, the exported imports are very common between clang module and it can lead to surprises if dependencies between clang modules end up exporting SPIs from unexpected modules. As a middle ground, reexport SPI only through Swift `@_exported` dependencies, and not through clang reexports. While this is a new distinction between Swift and clang dependencies, I believe it provides the expected behavior and the result is more straightforward than the current logic. rdar://115901208
xymus
force-pushed
the
spi-reexport-swift-only
branch
from
c7e90ca to
8b91e4c
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new attempt at a reexport feature for SPI decls. The previous behavior was to reexport SPI only between modules with both
@_exportedand an export-as relationship. The limitation on export-as turned out to be too restrictive in some cases.We may be tempted to reexport SPI through all exported imports. However, the exported imports are very common between clang module and it can lead to surprises if dependencies between clang modules end up exporting SPI from unexpected modules.
As a middle ground, reexport SPI only through Swift
@_exporteddependencies, and not through clang reexports. While this is a new distinction between Swift and clang dependencies, I believe it provides the expected behavior and the result is more straightforward than the current logic.rdar://115901208