Skip to content

Tests: Remove attr_availability_maccatalyst_implicit.swift #70568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

Cherry-pick of #70567.

This test was verifying the diagnostics emitted as a result of synthesized _modify accessors being generated with incorrect availability. As of #70533, the availability is no longer incorrect and therefore this test cannot verify anything useful.

Resolves rdar://119949219

@tshortli tshortli requested a review from a team as a code owner December 20, 2023 21:34
@tshortli tshortli requested a review from nkcsgexi December 20, 2023 21:34
@tshortli tshortli added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.10 labels Dec 20, 2023
@tshortli tshortli enabled auto-merge December 20, 2023 21:35
This test was verifying the diagnostics emitted as a result of synthesized
`_modify` accessors being generated with incorrect availability. As of
swiftlang#70533, the availability is no longer
incorrect and therefore this test cannot verify anything useful.

Resolves rdar://119949219
@tshortli tshortli force-pushed the remove-bad-maccatalyst-test-5.10 branch from f9fed5b to d494f55 Compare January 1, 2024 17:55
@tshortli
Copy link
Contributor Author

tshortli commented Jan 1, 2024

@swift-ci please test

@tshortli
Copy link
Contributor Author

tshortli commented Jan 2, 2024

@swift-ci please test Linux

@tshortli tshortli disabled auto-merge January 2, 2024 06:43
@tshortli tshortli merged commit dc8e9fe into swiftlang:release/5.10 Jan 2, 2024
@tshortli tshortli deleted the remove-bad-maccatalyst-test-5.10 branch January 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants