[3.1] Track the actual DC of a member access in the constraint system. #7059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, CSGen/CSSimplify and CSApply may have differing opinions about whether e.g. a let property is settable, which can lead to invalid ASTs. Arguably, a better fix would be to remove the dependency on the exact nested DC. For example, we could treat lets as settable in all contexts and then just complain later about invalid attempts to set them. Or we could change CSApply to directly use the information it already has about how an l-value is used, rather than trying to figure out whether it *might* be getting set. But somehow, tracking a new piece of information through the entire constraint system seems to be the more minimal change. Fixes rdar://29810997. (cherry picked from commit 39b65f4)
|
@swift-ci please test |
|
@dgregor Can I consider you as having reviewed this? :) |
|
@DougGregor I believe that last comment was meant for you :) |
|
@rjmccall yes, I reviewed & approved on the master PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, CSGen/CSSimplify and CSApply may have differing
opinions about whether e.g. a let property is settable, which
can lead to invalid ASTs.
Arguably, a better fix would be to remove the dependency on the
exact nested DC. For example, we could treat lets as settable
in all contexts and then just complain later about invalid
attempts to set them. Or we could change CSApply to directly
use the information it already has about how an l-value is used,
rather than trying to figure out whether it might be getting set.
But somehow, tracking a new piece of information through the
entire constraint system seems to be the more minimal change.
Fixes rdar://29810997.