Skip to content

[CMake] Change include path in HeaderDependencies.cpp #70597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

cachemeifyoucan
Copy link
Contributor

Update the #include in generated HeaderDependencies.cpp so it doesn't need a special include path that points into include/swift. In the swift sub-directory, there is a Strings.h that can be mistaken as <string.h> on a case-insensitive file system.

rdar://119997353

Update the #include in generated HeaderDependencies.cpp so it doesn't
need a special include path that points into `include/swift`. In the
swift sub-directory, there is a `Strings.h` that can be mistaken as
<string.h> on a case-insensitive file system.

rdar://119997353
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test macOS platform

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cachemeifyoucan cachemeifyoucan merged commit 234e61b into swiftlang:main Jan 2, 2024
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-119997353 branch January 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants