[RemoteMirror] Use __attribute__((deprecated)) instead of [[deprecated]]. #70598
Conversation
| @@ -188,7 +188,7 @@ swift_reflection_typeRefForMangledTypeName(SwiftReflectionContextRef ContextRef, | |||
| /// | |||
| /// The returned string is heap allocated and the caller must free() it when | |||
| /// done. | |||
| [[deprecated("Please use swift_reflection_copyNameForTypeRef()")]] | |||
| __attribute__((deprecated("Please use swift_reflection_copyNameForTypeRef()"))) | |||
There was a problem hiding this comment.
This header may be included by MSVC as well right? I think that we should use LLVM_DEPRECATED. The [[deprecated(...)]] syntax is part of C23 I think, which is why it was "safe".
There was a problem hiding this comment.
That makes sense. I didn't realize we had that macro and didn't find it when looking for one.
LLVM defines it as:
#if defined(__clang__)
#define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
#else
#define LLVM_DEPRECATED(MSG, FIX) [[deprecated(MSG)]]
#endif
Is the [[]] syntax always going to be OK in the non-clang case? Seems like, if LLVM uses it, but I'm not sure if it uses this in C headers.
There was a problem hiding this comment.
I don't think that it is always safe in the else case, but currently the CI is only covering clang and MSVC. It should be okay with any C23 capable compiler. I don't believe that these are guarded by __cplusplus.
There was a problem hiding this comment.
We don't include any LLVM headers here, so I stole the definition for a SWIFT_REMOTE_MIRROR_DEPRECATED that we can use here.
mikeash
force-pushed
the
fix-swift-inspect-attribute
branch
from
1e96488 to
d8ab23a
Compare
| @@ -41,6 +41,13 @@ extern "C" { | |||
| # endif | |||
| #endif | |||
|
|
|||
| #if defined(__clang__) | |||
| #define SWIFT_REMOTE_MIRROR_DEPRECATED(MSG, FIX) \ | |||
| __attribute__((deprecated(MSG, FIX))) | |||
There was a problem hiding this comment.
Would be nice to use the reserved spelling: __attribute__((__deprecated__(MSG, FIX)))
…d]]. Use __attribute__((deprecated)) in SwiftRemoteMirror.h as it needs to be includable from C.
mikeash
force-pushed
the
fix-swift-inspect-attribute
branch
from
d8ab23a to
679db9a
Compare
|
@swift-ci please test |
Use
__attribute__((deprecated))in SwiftRemoteMirror.h as it needs to be includable from C.