Skip to content

Clear out the SchedulerPrivate fields before enqueueing the task #70603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

rokhinip
Copy link
Contributor

Clear out the SchedulerPrivate fields before enqueueing the task into the executor

@rokhinip rokhinip requested review from ktoso and kavon as code owners December 22, 2023 03:25
@rokhinip
Copy link
Contributor Author

@swift-ci please test

@rokhinip rokhinip enabled auto-merge December 22, 2023 03:25
auto-merge was automatically disabled January 2, 2024 05:57

Base branch was modified

@ktoso
Copy link
Contributor

ktoso commented Jun 27, 2024

Should we still do this? LGTM

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Jun 27, 2024
@ktoso ktoso requested a review from mikeash June 27, 2024 13:12
@rokhinip
Copy link
Contributor Author

Good question, I can't remember what issue I was facing when I made this change but it does look reasonable so I'm going to merge

@rokhinip rokhinip merged commit 1f466c2 into main Jun 27, 2024
5 checks passed
@rokhinip rokhinip deleted the rokhinip/clear-scheduler-private-fields-executor branch June 27, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants