waitQueue.compare_exchange_strong in the true loop can be weak #70636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
force-pushed
the
queue
branch
2 times, most recently
from
331ecfb to
301bca1
Compare
weak is more suitable for this while loop than strong.
|
@swift-ci please test |
kavon
approved these changes
Jan 8, 2024
|
I think this is still functionally correct and may yield better performance on certain platforms. When I initially changed these two compare-exhanges to strong in this PR, I was a bit overzealous. If you could also simplify the one I'd like a review from @ktoso or someone else before merging. |
|
@swift-ci please test windows platform |
ktoso
approved these changes
Jan 9, 2024
ktoso
added
the
concurrency runtime
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weak is more suitable for this while loop than strong.