[region-isolation] Initial refactoring work for supporting Transferring Args and Results #70653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
force-pushed
the
transferring
branch
from
d617692 to
6c5b7c9
Compare
|
Just beginning to test out some support/refactoring that I am doing here before adding in the larger part of work here. Specifically, I am using code already in tree to do some early testing. |
|
@swift-ci test |
|
@swift-ci test |
…ork for general experimental features instead of just NonEscapableTypes.
… than passing around a bunch of state. Just refactoring before adding /another/ field to these APIs. It hurt to do so so I needed to refactor. NFCI.
gottesmm
changed the title
gottesmm
requested review from
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro and
tshortli
as code owners
|
@swift-ci smoke test |
xedin
reviewed
Jan 2, 2024
|
Actual swift-syntax PR: swiftlang/swift-syntax#2411 |
|
@swift-ci smoke test |
xedin
approved these changes
Jan 2, 2024
…eter to use an OptionSet so we can add other options. I am doing this in preparation for adding options to SILParameterInfo/ SILResultInfo that state that a parameter/result is transferring. Even though I could have just introduced a new bit here, I instead streamlined the interface of SILParameterInfo/SILResultInfo to use an OptionSet instead of individual bits to make it easier to add new flags here. The reason why it is easier is that along API (e.x.: function argument) boundaries one does not have to marshal each field or pass each field. Instead one can just pass the whole OptionSet as an opaque thing. Using this I was able to change serialization/deserialization of SILParameterInfo/SILResultInfo so that one does not need to update them if one adds new fields! The reason why I am doing this for both SILParameterInfo/SILResultInfo in the same commit is because they share code in the demangler that I did not want to have to duplicate in an intervening commit. By changing them both at the same type, I didn't have to change anything without an actual need to. I am doing this in a separate commit from adding transferring support so I can validate correctness using the tests for the options already supported (currently only differentiability).
Just splitting off a larger commit to make this easier to review.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in progress.