[Frontend] Diagnose rather than exit/assert on experimental features #70672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnose rather than exit when using experimental features that cannot be enabled in production. Also diagnose if using a compiler without `SwiftCompilerSources` when enabling embedded. This is especially important for long-running services like sourcekitd, which shouldn't exit just because an invalid argument was passed. Resolves rdar://119724074.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
kubamracek
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose rather than exit when using experimental features that cannot be enabled in production. Also diagnose if using a compiler without
SwiftCompilerSourceswhen enabling embedded.This is especially important for long-running services like sourcekitd, which shouldn't exit just because an invalid argument was passed.
Resolves rdar://119724074.