[AutoDiff] Add missing vjp, jvp functions to existing FloatingPoint initializers #70688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2024 15:48
Adds derivatives to already existing initializers that allow converting between floating point type. For example converting a Float to a Double.
|
Tagging @BradLarson |
|
@swift-ci Please test |
rxwei
approved these changes
Jan 5, 2024
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
…nitializers (swiftlang#70688) Adds derivatives to already existing initializers that allow converting between floating point type. For example converting a Float to a Double. Co-authored-by: Jaap Wijnen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds jvp's and vjp's to already existing FloatingPoint initializers that allow to convert between floating point types, making the example below differentiable:
Previously jvp's and vjp's were added to the FloatingPoint initializers that took the same FP type as an argument in #64417 . But not to the initializers taking other FP types as arguments (for example converting from a Float to a Double).