Use %target-swiftc_driver in objc_class_properties_runtime.swift #70689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please build toolchain |
compnerd
reviewed
Jan 3, 2024
This way we will compile the test program with `-Xlinker -headerpad_max_install_names`, which will allow `swift-darwin-postprocess.py` to amend the install names without errors. Take the chance to remove the `-target` parameter -- that is already provided by %target-swiftc_driver, and we have no need to enforce it to be at least `macosx10.11` (since by virtue of build-script defaults and Xcode in CI we don't support anything lower than `macosx10.13`) Addresses rdar://119907089
edymtt
force-pushed
the
edymtt/use-target-swiftc-driver-for-objc_class_properties_runtime
branch
from
2c2c1b8 to
ea5d416
Compare
|
@swift-ci please test |
|
@swift-ci please build toolchain |
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
…ftlang#70689) This way we will compile the test program with `-Xlinker -headerpad_max_install_names`, which will allow `swift-darwin-postprocess.py` to amend the install names without errors. Take the chance to remove the `-target` parameter -- that is already provided by %target-swiftc_driver, and we have no need to enforce it to be at least `macosx10.11` (since by virtue of build-script defaults and Xcode in CI we don't support anything lower than `macosx10.13`) Addresses rdar://119907089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we will compile the test program with
-Xlinker -headerpad_max_install_names, which will allowswift-darwin-postprocess.pyto amend the install names without errors.Take the chance to remove the
-targetparameter -- that is alreadyprovided by %target-swiftc_driver, and we have no need to enforce it to
be at least
macosx10.11(since by virtue of build-script defaults andXcode in CI we don't support anything lower than
macosx10.13)Addresses rdar://119907089