Fix variadic-generic class method dispatch #70707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to map formal types into the new environment.
with walking the tuple so that they can be used without an address.
patterns) in argument positions in reabstraction thunks. Most of the difficulty in this work continues to center around (1) trying to reuse as much code as possible between the parameter and result paths and (2) propagating ownership information as necessary throughout the code. I did my best to assert the preconditions and postconditions here, but undoubtedly I'm missing cases. Some simplicity here is still eluding me here. This patch necessarily changes quite a bit of the code used in non-variadic paths. I tried to avoid doing things that I knew would be risky, like optimizing copies. I did fail in a few places: e.g. we should now generate significantly better code when erasing to Optional<Any>, just because the code was oddly poorly-factored before. You can see the effect on the function_conversion test case.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important to set substitutions on generic abstraction patterns so that we can maintain the parallel structure with the substituted type properly.
Builds on top of #70681.
Part of the fix for rdar://119899063