[indexer] Fix crash in initVarRefIndexSymbols by handling references from 'import var ...' #7072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2017 16:36
…ferences in ImportDecls IndexSwiftASTWalker::initVarRefIndexSymbols wasn't handling getCurrentExpr() returning a nullptr as it does when processing a reference to someVar in the below import: import var SomeModule.someVar This patch fixes rdar://problem/30118572 and adds tests for import var/func references.
…its now more general
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexSwiftASTWalker::initVarRefIndexSymbols wasn't handling
getCurrentExpr()returning a nullptr (passed via theCurrentEparam), but this happens whenever we're processing a reference within an import, e.g.someVarin:import var SomeModule.someVarThis patch fixes the crash and adds support for indexing
import var/funcreferences.Resolves rdar://problem/30118572