Skip to content

[Caching] Preliminary simple macro support for caching #70724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented Jan 4, 2024

Preliminary caching support for macro:

  • Inserting the plugin into the CASFS
  • Lookup plugin via physical file system

For future better support, we should teach dependency scanner to resolve macros and return the resolved plugins to swift-frontend.

rdar://121873571

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-basic-macro-support-caching branch 2 times, most recently from ee01452 to 66ff487 Compare March 21, 2024 17:19
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-basic-macro-support-caching branch from 66ff487 to 37701e7 Compare March 28, 2024 22:53
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-basic-macro-support-caching branch from 37701e7 to 59c2828 Compare April 6, 2024 00:30
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

Preliminary caching support for macro:
* Inserting the plugin into the CASFS
* Lookup plugin via physical file system

For future better support, we should teach dependency scanner to resolve
macros and return the resolved plugins to swift-frontend.

rdar://121873571
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-basic-macro-support-caching branch from 59c2828 to daa1065 Compare April 8, 2024 16:41
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

ping

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. cc @rintaro just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants