Sema: Error for potentially unavailable conformances in Swift 6 #70730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostics about use of potentially unavailable conformances had to be downgraded to warnings in Swift 5 in order to preserve source compatibility. These diagnostics should be errors by default in Swift 6. Resolves rdar://88210812
Now that the diagnostics are automatically errors in Swift 6, we don't need an `-enable-conformance-availability-errors` flag to control whether unavailable conformances are diagnosed as errors. Nobody was using the flag so it should be safe to remove. Part of rdar://88210812
tshortli
force-pushed
the
potentially-unavailable-conformance-error-swift6
branch
from
467f767 to
41c4143
Compare
|
@swift-ci please test |
beccadax
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostics about use of potentially unavailable conformances had to be downgraded to warnings in Swift 5 in order to preserve source compatibility. These diagnostics should be errors by default in Swift 6.
Now that the diagnostics are automatically errors in Swift 6, we don't need an
-enable-conformance-availability-errorsflag to control whether unavailable conformances are diagnosed as errors. Nobody was using the flag so it should be safe to remove.Resolves rdar://88210812