[AST] Requestify local type declarations #70737
Conversation
Instead of recording local type declarations while parsing, make a request to collect them from the AST. This reduces the side effect of parsing.
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please Test Source Compatibility |
| case DeclKind::Struct: | ||
| case DeclKind::Class: | ||
| case DeclKind::Protocol: | ||
| case DeclKind::TypeAlias: |
There was a problem hiding this comment.
I'm not really sure we need TypeAlias here. IRGen and SILGen don't seem to handle them. Maybe isa<NominalTypeDecl>(D) might be better?
There was a problem hiding this comment.
It seems reasonable to keep type aliases here so that this request returns all local types, even if IRGen and SILGen don't care. Debugging and module emission probably care, for example.
| case DeclKind::Struct: | ||
| case DeclKind::Class: | ||
| case DeclKind::Protocol: | ||
| case DeclKind::TypeAlias: |
There was a problem hiding this comment.
It seems reasonable to keep type aliases here so that this request returns all local types, even if IRGen and SILGen don't care. Debugging and module emission probably care, for example.
| @@ -1444,7 +1444,8 @@ void SourceFile::getPrecedenceGroups( | |||
| } | |||
|
|
|||
| void SourceFile::getLocalTypeDecls(SmallVectorImpl<TypeDecl*> &Results) const { | |||
There was a problem hiding this comment.
I might be missing a reference, but I believe the only two uses of this can just be replaced with getLocalTypeDecls() - neither use mutates the vector after retrieving them.
There was a problem hiding this comment.
Module::getLocalTypeDecl() calls FileUnit::getLocalTypeDecls(SmallVectorImpl<TypeDecl*>). Since SerializedASTFile doesn't hold them as a list of TypeDecl * we can't simply make it return ArrayRef.
Instead of recording local type declarations while parsing, make a request to collect them from the AST.
This reduces the side effect of parsing.