Macro expansion scopes are inserted at the last character in their insertion range #70740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sertion range Macro expansion scope ranges are in terms of characters, so the end of the insertion range is one past the last character of the insertion range. If the last character in the insertion range is also the last character in the enclosing scope, we would build the scope tree incorrectly. Adjust the position for scope creation to the last character in the insertion range, not one past it. Fixes rdar://120559184.
|
@swift-ci please smoke test |
|
This should resolve #70733 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro expansion scope ranges are in terms of characters, so the end of the insertion range is one past the last character of the insertion range. If the last character in the insertion range is also the last character in the enclosing scope, we would build the scope tree incorrectly.
Adjust the position for scope creation to the last character in the insertion range, not one past it. Fixes rdar://120559184, #70733.