[region-isolation] Refactor out the Region analysis from TransferNonSendable. #70748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-3175a8b536ca96190c616af15a2c7865a6f1fbe3
branch
from
1788fdb to
466a10a
Compare
|
@swift-ci smoke test |
…endable. NFCI. This is just a pure refactor of the analysis part of TransferNonSendable into a separate SIL level analysis so it can be reused by other passes. The reason that I am committing this earlier is that I am working concurrently on other patches that change TransferNonSendable itself and I want to avoid issues when rebasing those patches. Getting this patch into tree earlier avoids that. This is in preparation for adding a new flow sensitive initialization pass that combines region based analysis with the current flow sensitive isolation's diagnostic emitter. The idea is that we want to preserve the diagnostics from that pass rather than try to make our own as an initial step.
…hat we do not support. Before this commit, this was done at the beginning of TransferNonSendable. I thought that those checks would be sufficient to ensure that RegionAnalysisFunctionInfo was not created for functions that we do not support. Turns out when we perform certain forms of verification, we force all function analyses to be created for all functions meaning that we would create a RegionAnalysisFunctionInfo for such an unsupported function causing us to hit asserts. In this commit, I move the check to whether or not we support a function into RegionAnalysisFunctionInfo itself and use that to determine if we should run TransferNonSendable. This additionally allows me to change RegionAnalysisFunctionInfo so that one can construct one for an unsupported function... as long as one doesn't actually touch any of its methods. If one does, I put in an assert so we will know that operator error has occured.
gottesmm
force-pushed
the
pr-3175a8b536ca96190c616af15a2c7865a6f1fbe3
branch
from
466a10a to
053e30d
Compare
|
Just rebased |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFCI. This is just a pure refactor of the analysis part of TransferNonSendable into a separate SIL level analysis so it can be reused by other passes.
The reason that I am committing this earlier is that I am working concurrently on other patches that change TransferNonSendable itself and I want to avoid issues when rebasing those patches. Getting this patch into tree earlier avoids that.
This is in preparation for adding a new flow sensitive initialization pass that combines region based analysis with the current flow sensitive isolation's diagnostic emitter. The idea is that we want to preserve the diagnostics from that pass rather than try to make our own as an initial step.