[Concurrency] Allow isolated parameters to have optional type. #70758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
force-pushed
the
generalize-isolated-param
branch
5 times, most recently
from
8ba4dad to
b8fa2ac
Compare
hborla
requested review from
ktoso,
kavon,
AnthonyLatsis,
slavapestov,
xedin and
tshortli
as code owners
… the LowerHopToActor pass instead of during SILGen.
…lues in LowerHopToActor. In order to project an optional executor value from an optional actor value, the executor lowering needs to modify the CFG. This is done by splitting LowerHopToActor into two passes. The first pass records all actor operands of hop_to_executor and extract_executor instructions and records the dominating instruction that will derive the executor value. The second pass iterates over the multi-map of dominating instructions, derives the executor value, and rewrites the operands of all reachable hop_to_executor and extract_executor instructions to reuse that executor value.
hborla
force-pushed
the
generalize-isolated-param
branch
from
f651a14 to
5858e52
Compare
|
@swift-ci please test |
hborla
force-pushed
the
generalize-isolated-param
branch
from
5858e52 to
74d7a25
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow isolated parameters to have optional type. This is the primary generalization of isolated parameters described in https://github.com/apple/swift-evolution/blob/d4bfe25e12115f70b691f782a2dc99a7a7d1406a/proposals/NNNN-generalize-async-sequence.md#generalized-isolated-parameters.
This change requires the
hop_to_executorinstruction to handle optional actor operands in SILGen. TheLowerHopToActorpass then projects out the optional executor value from the optional actor value.LowerHopToActorinserts the executor derivation in dominating position to allow reusing the executor value in reachablehop_to_executorinstructions, but dominance analysis relies on the CFG not changing. This is handled by changingLowerHopToActorto perform two passes over the given function:hop_to_executorandextract_executorinstructions and records the dominating instruction that will derive the executor value.hop_to_executorandextract_executorinstructions to use that executor value.Writing optional isolated parameters in source is currently gated behind
-enable-experimental-feature OptionalIsolatedParameters.