Skip to content

[embedded] Add Dictionary to embedded stdlib #70762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 17, 2024
Merged

[embedded] Add Dictionary to embedded stdlib #70762

merged 5 commits into from
Jan 17, 2024

Conversation

kubamracek
Copy link
Contributor

This is a straightforward addition of Dictionary to the embedded stdlib, same as how Array and Set is done. Namely:

  • Carve out CustomStringConvertible, CustomDebugStringConvertible conformances
  • Disallow casting, bridging, and non-native representations
  • Define the empty singleton as a Swift global variable (with the same caveats as Array and Set have)
  • Dumb down the error reporting in KEY_TYPE_OF_DICTIONARY_VIOLATES_HASHABLE_REQUIREMENTS
  • Add tests

@kubamracek kubamracek requested a review from a team as a code owner January 8, 2024 13:20
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek added the embedded Embedded Swift label Jan 8, 2024
@kubamracek
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test

2 similar comments
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek enabled auto-merge January 16, 2024 22:02
@kubamracek kubamracek merged commit 10ea278 into swiftlang:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

@rauhul rauhul Awaiting requested review from rauhul

@zoecarver zoecarver Awaiting requested review from zoecarver

@eeckstein eeckstein Awaiting requested review from eeckstein

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees
No one assigned
Labels
embedded Embedded Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubamracek @phausler