AST: Fix compareDependentTypes() for protocol typealiases #7081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
DougGregor
approved these changes
Jan 27, 2017
| @@ -1221,6 +1221,7 @@ CanType TypeBase::getCanonicalType() { | |||
|
|
|||
| Result = GenericFunctionType::get(sig, inputTy, resultTy, | |||
| function->getExtInfo()); | |||
| // assert(function->hasError() || !Result->hasError()); | |||
There was a problem hiding this comment.
Did you mean to remove this?
There was a problem hiding this comment.
It looks like a nice assert but it made some compiler_crashers regress... so I'll look into this later.
slavapestov
force-pushed
the
protocol-typealiases-are-fun
branch
from
bd0e7b1 to
05a6d06
Compare
We must order protocol typealiases *after* other types, so that if a protocol typealias is equal to an associated type, the representative is chosen to be the associated type and not the typealias. Fixes <https://bugs.swift.org/browse/SR-3687> and <rdar://problem/30118513>.
slavapestov
force-pushed
the
protocol-typealiases-are-fun
branch
from
05a6d06 to
f9789ce
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.swift.org/browse/SR-3687 and rdar://problem/30118513.