[Serialization] Always serialize module-defining .swiftinterface, even if SDK-relative.
#70817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
SerializeInterfacePathWhenBuildBinaryModule
branch
from
6d51bed to
1608523
Compare
xymus
approved these changes
Jan 10, 2024
artemcm
force-pushed
the
SerializeInterfacePathWhenBuildBinaryModule
branch
2 times, most recently
from
5d3699f to
5a47a3f
Compare
|
@swift-ci smoke test |
…ven if SDK-relative. The clients, upon loading, will resolve the SDK-relative path to their SDK location. Resolves rdar://120673684
artemcm
force-pushed
the
SerializeInterfacePathWhenBuildBinaryModule
branch
from
5a47a3f to
de626ab
Compare
|
@swift-ci smoke test |
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Jul 3, 2024
…ing interface for prebuilt binary Swift dependencies When the dependency scanner picks a pre-built binary module candidate for a given dependency, it needs to be able to attempt to resolve its cross-import overlays relative to the textual interface that the binary module was built from. For example, if a collection of binary modules are located in, and resolved as dependencies from, a pre-built module directory, the scanner must lookup their corresponding cross-import overlays relative to the defining interface as read out from the binary module's MODULE_INTERFACE_PATH. swiftlang#70817 ensures that binary modules serialize the path to their defining textual interface. Resolves rdar://130778577
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Jul 3, 2024
…ing interface for prebuilt binary Swift dependencies When the dependency scanner picks a pre-built binary module candidate for a given dependency, it needs to be able to attempt to resolve its cross-import overlays relative to the textual interface that the binary module was built from. For example, if a collection of binary modules are located in, and resolved as dependencies from, a pre-built module directory, the scanner must lookup their corresponding cross-import overlays relative to the defining interface as read out from the binary module's MODULE_INTERFACE_PATH. swiftlang#70817 ensures that binary modules serialize the path to their defining textual interface. Resolves rdar://130778577
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Jul 3, 2024
…ing interface for prebuilt binary Swift dependencies When the dependency scanner picks a pre-built binary module candidate for a given dependency, it needs to be able to attempt to resolve its cross-import overlays relative to the textual interface that the binary module was built from. For example, if a collection of binary modules are located in, and resolved as dependencies from, a pre-built module directory, the scanner must lookup their corresponding cross-import overlays relative to the defining interface as read out from the binary module's MODULE_INTERFACE_PATH. swiftlang#70817 ensures that binary modules serialize the path to their defining textual interface. Resolves rdar://130778577
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Jul 4, 2024
…ing interface for prebuilt binary Swift dependencies When the dependency scanner picks a pre-built binary module candidate for a given dependency, it needs to be able to attempt to resolve its cross-import overlays relative to the textual interface that the binary module was built from. For example, if a collection of binary modules are located in, and resolved as dependencies from, a pre-built module directory, the scanner must lookup their corresponding cross-import overlays relative to the defining interface as read out from the binary module's MODULE_INTERFACE_PATH. swiftlang#70817 ensures that binary modules serialize the path to their defining textual interface. Resolves rdar://130778577
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Jul 8, 2024
…ing interface for prebuilt binary Swift dependencies When the dependency scanner picks a pre-built binary module candidate for a given dependency, it needs to be able to attempt to resolve its cross-import overlays relative to the textual interface that the binary module was built from. For example, if a collection of binary modules are located in, and resolved as dependencies from, a pre-built module directory, the scanner must lookup their corresponding cross-import overlays relative to the defining interface as read out from the binary module's MODULE_INTERFACE_PATH. swiftlang#70817 ensures that binary modules serialize the path to their defining textual interface. Resolves rdar://130778577
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Jul 8, 2024
…ing interface for prebuilt binary Swift dependencies When the dependency scanner picks a pre-built binary module candidate for a given dependency, it needs to be able to attempt to resolve its cross-import overlays relative to the textual interface that the binary module was built from. For example, if a collection of binary modules are located in, and resolved as dependencies from, a pre-built module directory, the scanner must lookup their corresponding cross-import overlays relative to the defining interface as read out from the binary module's MODULE_INTERFACE_PATH. swiftlang#70817 ensures that binary modules serialize the path to their defining textual interface. Resolves rdar://130778577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clients, upon loading, will resolve the SDK-relative path to their SDK location.
Resolves rdar://120673684