[region-isolation] Add support for transferring parameters. #70836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
ktoso,
kavon,
AnthonyLatsis,
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci smoke test |
ktoso
reviewed
Jan 11, 2024
|
@swift-ci smoke test |
gottesmm
force-pushed
the
transferring-parameter
branch
from
5f1b488 to
f623b4e
Compare
|
@swift-ci smoke test |
|
(just rebasing/retesting since I am back from vacation) |
|
Looks like the windows/macOS failures are related to swiftpm |
|
@swift-ci smoke test |
…a transferring OwnershipSpecifier.
NOTE: This does not handle yet assignment into transferring parameters. In the next commit, I am going to teach the checker that assigning into such a parameter is a transfer.
…ferring parameter is a transfer of the value. The specific semantics is if we assign into a transferring parameter's field, then we "merge" src's value into the transferring parameter, so we conservatively leave the region of the transferring parameter alone. If we assign over the entire transferring parameter, we perform an assign fresh since any value that used to be in the transferring parameter cannot reference anything in its new value since they are all gone.
…d optionals. llvm::Optional<T> used to make it so that in asserts builds if one dereferenced the optional and nothing was there, one would get an assert. std::optional<T> does not have that property.
…r being strongly transferred is an error. Before the previous patch, we were just getting lucky on macOS due to UB. Now that the UB is fixed, we correctly crash without this commit since we were not pattern matching the simple case of a local value that was transferred and used later.
gottesmm
force-pushed
the
transferring-parameter
branch
2 times, most recently
from
c50e171 to
eb57309
Compare
|
@swift-ci smoke test |
|
I got feedback from some people about some small changes about loosening the rules around assigning into a transferring parameter. I am going to do that in a follow on commit. This at least gets in the basics and ensures that I do not hit more merge conflicts around Serialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transferring parameter is a consuming like param modifier that can be used to transfer values to an async function such that you can transfer the value further.
Since it is consuming, one can assign into it. When one assigns into it, one has transferred the new value into the transferred parameter.