CMake: on Darwin be explicit about inclusion in the dyld shared cache #70856
Conversation
|
@swift-ci please test |
|
@swift-ci please build toolchain |
There was a problem hiding this comment.
Do we need to use the generator expressions here? I might be missing something so correct me if I'm wrong, but it looks like these are configuration-time booleans? If it is, can we stick with if statements? They're easier to debug since they show up in the output of --trace-expand instead of having to track it down in the build.ninja file.
edymtt
force-pushed
the
edymtt/darwin-stdlib-shared-cache
branch
from
efb9f7c to
fc60c6c
Compare
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
I used generator expressions based on the feedback on a past PR that dealt with linker flags, assuming it was the preferred approach going forward -- likely I missed the context there and thought I could apply that verbatim here. Reworked this in fc60c6c To answer your second question: yes, I'm using configuration-time booleans. |
edymtt
force-pushed
the
edymtt/darwin-stdlib-shared-cache
branch
from
fc60c6c to
abac682
Compare
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci please test |
|
@swift-ci please build toolchain |
This entails passing a linker flags to Apple linkers when the standard library is not meant for inclusion in such cache. For this to have effect on every library, propagate link flags when building _Concurrency and Observation. This is needed for Apple internal configurations. Addresses rdar://120653968
edymtt
force-pushed
the
edymtt/darwin-stdlib-shared-cache
branch
from
abac682 to
d84140d
Compare
|
Good point, I totally forgot to check Synchronization when marking this PR as ready to review -- tackling that in d84140d (and adding the missing newline while I'm at it) |
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci please build toolchain Windows |
…swiftlang#70856) This entails passing a linker flags to Apple linkers when the standard library is not meant for inclusion in such cache. For this to have effect on every library, propagate link flags when building _Concurrency and Observation. This is needed for Apple internal configurations. Addresses rdar://120653968
This entails passing a linker flags to Apple linkers when the standard library is not meant for inclusion in such cache.
For this to have effect on every library, propagate link flags when building _Concurrency and Observation.
This is needed for Apple internal configurations.
Addresses rdar://120653968