[CMake] Propagate header changes to pure Swift modules #70859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the headers imported by Swift files aren't not correctly propagated in CMake/Ninja. So changes to C/C++ headers didn't rebuild ASTGen modules. Move the similar hack from SwiftCompilerSources and use it in ASTGen as well. rdar://120863405
rintaro
commented
Jan 11, 2024
| cmake_parse_arguments(ARGS "PUBLIC;PRIVATE;INTERFACE" "" "" ${ARGN}) | ||
| foreach(DEPENDENCY ${ARGS_UNPARSED_ARGUMENTS}) | ||
| function(force_add_dependencies TARGET) | ||
| foreach(DEPENDENCY ${ARGN}) |
There was a problem hiding this comment.
Split force_target_link_libraries so that we can just add dependencies without linking.
rintaro
commented
Jan 11, 2024
| # | ||
| # TODO: generate this dynamically through the modulemap; this cannot use `sed` | ||
| # as that is not available on all platforms (e.g. Windows). | ||
| file(GENERATE |
There was a problem hiding this comment.
file(GENERATE only updates the file when the content has changed. We don't need the .tmp/add_custom_command hack.
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Jan 12, 2024
etcwilde
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the headers imported by Swift files aren't not correctly propagated in CMake/Ninja. So Modifying C/C++ headers didn't rebuild ASTGen modules. Move the similar hack from SwiftCompilerSources and use it in ASTGen as well.
rdar://120863405