🍒 [SE-0412] changelog note about strict concurrency for global variables #70863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiapoirier
force-pushed
the
global-variable-strict-concurrency-changelog-5.10
branch
from
ef1c709 to
2957b1e
Compare
hborla
reviewed
Jan 12, 2024
| @@ -5,6 +5,16 @@ | |||
|
|
|||
| ## Swift 5.10 | |||
|
|
|||
| * [SE-0412][]: | |||
|
|
|||
| Under strict concurrency checking, every global or static variable must be either isolated to a global actor or be both immutable and of `Sendable` type. | |||
There was a problem hiding this comment.
Can you show an example of some code that previously could exhibit data races at runtime that is now diagnosed under the proposal?
sophiapoirier
force-pushed
the
global-variable-strict-concurrency-changelog-5.10
branch
from
2957b1e to
4ef9e50
Compare
|
The changelog item is added under Swift 5.10 here, but under Swift 5.11 on the main branch. In both pull requests, a reference is missing (at the end of the changelog): [SE-0412]: <https://github.com/apple/swift-evolution/blob/main/proposals/0412-strict-concurrency-for-global-variables.md> |
sophiapoirier
force-pushed
the
global-variable-strict-concurrency-changelog-5.10
branch
from
4ef9e50 to
666a70d
Compare
|
@swift-ci please test |
Ah good point, I modeled the same as was done with SE-0411 without much thinking about it. I have now on main also moved SE-0411 under 5.10 (@hborla I hope you agree that is the correct change).
Thanks and fixed now. |
hborla
approved these changes
Jan 13, 2024
sophiapoirier
changed the title
sophiapoirier
deleted the
global-variable-strict-concurrency-changelog-5.10
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.