[TypeChecker/SILGen] Dynamic enforcement of witness/objc isolation with @preconcurrency attribute #70867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ktoso,
kavon,
AnthonyLatsis,
hborla,
slavapestov,
artemcm,
tshortli,
zoecarver,
hyp,
egorzhdan,
ahoppen,
bnbarham,
CodaFi,
hamishknight and
rintaro
as code owners
xedin
force-pushed
the
dynamic-enforcement-of-witness-isolation-with-preconcurrency
branch
from
f2c5e44 to
ae4662d
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
slavapestov
reviewed
Jan 16, 2024
| @@ -1604,11 +1604,15 @@ struct InheritedEntry : public TypeLoc { | |||
| /// Whether there was an @retroactive attribute. | |||
| bool isRetroactive = false; | |||
|
|
|||
| /// Whether there was an @preconcurrency attribute. | |||
| bool isPreconcurrency = false; | |||
There was a problem hiding this comment.
Should these be bitfields?
slavapestov
reviewed
Jan 16, 2024
| /// conformances" bits. | ||
| llvm::PointerIntPair<DeclContext *, 3, unsigned> ContextAndBits; | ||
|
|
||
| /// Indicates whether the conformance is invalid. | ||
| bool Invalid : 1; |
There was a problem hiding this comment.
You can combine the bits from ContextAndBits and SourceKindAndImplyingConformance with 'Invalid' into a single bitfield
There was a problem hiding this comment.
We discussed this offline with Slava and I'm going to follow-up with bitfield changes in a separate PR.
…mances Suppress warnings/errors when actor isolated synchroneous witness is matched against `@preconcurrency` conformance requirement. Witness thunk assumes isolation of the witness but instead of a hop to its executor it would emit a runtime check to make sure that its always called from the expected context.
…d @preconcurrency witness thunks For `@preconcurrency` conformance witness thunks replace hop to executor with a precondition to make sure that the thunk is always called in the expected context.
…at adopted concurrency Don't treat isolated or explicitly `nonisolated` requirements as preconcurrency because in that case we consider protocol as concurrency adopter.
xedin
force-pushed
the
dynamic-enforcement-of-witness-isolation-with-preconcurrency
branch
from
ae4662d to
1caafee
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of
@preconcurrencyconformances and dynamic actor isolation enforcement that comes with them.The PR:
@preconcurrencyattribute available in inheritance clauses of types and extensions@objcthunks to make sure that calls happens on expected executor.@preconcurrencyattributes on conformances as having no effect when no diagnostics were suppressed by them.Resolves: rdar://102342433
Resolves: rdar://80972126