[Runtime] Fix AbsoluteFuncPtr to allow template parameter inference
#70878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AbsoluteFunctionPointer` was not able to be passed to a function that takes a `TargetCompactFunctionPointer` because the template parameters `Nullable` and `Offset` were not parameterized by `AbsoluteFunctionPointer`. 29c350e introduced the first such function `InProcessReaderWriter::resolveFunctionPointer` and it revealed this issue.
|
@swift-ci Please smoke test |
kateinoigakukun
deleted the
pr-02f4c271b06b6ca3f0607bf3b7d5051130b61b08
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbsoluteFunctionPointerwas not able to be passed to a function that takes aTargetCompactFunctionPointerbecause the template parametersNullableandOffsetwere not parameterized byAbsoluteFunctionPointer.29c350e introduced the first such function
InProcessReaderWriter::resolveFunctionPointerand it revealed this issue.This only affects WebAssembly build ATM.