Skip to content

[Parse] Parse subscript with '#' expressions #7089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2017
Merged

[Parse] Parse subscript with '#' expressions #7089

merged 1 commit into from
Jan 30, 2017

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jan 27, 2017

Fixes: SR-3439

Currently, [ before # are tokenized as tok::l_square_lit.
In this PR, the parser fix it to tok::l_square before parsing subscript-expression.

@rintaro
Copy link
Member Author

rintaro commented Jan 27, 2017

@swift-ci Please smoke test

@rintaro rintaro force-pushed the parse-subscript-pound branch from 73f90f9 to 590ac72 Compare January 27, 2017 11:00
@rintaro
Copy link
Member Author

rintaro commented Jan 27, 2017

@swift-ci Please smoke test

@slavapestov slavapestov merged commit 11aee8f into swiftlang:master Jan 30, 2017
@rintaro rintaro deleted the parse-subscript-pound branch January 30, 2017 05:20
@rintaro rintaro mannequin mentioned this pull request Jan 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @slavapestov