Skip to content

[CMake] Move swift-syntax library definitions to 'lib/SwiftSyntax' #70893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jan 12, 2024

Previously, swift-syntax libraries were built in the root CMakeLists.txt, and were installed in lib/CMakeLists.txt. Consolidate them into lib/SwiftSyntax/CMakeLists.txt. Now the swift-syntax libraries look like any other tool libraries outside lib/SwiftSyntax, as they should.

Previously, swift-syntax libraries were built in '/CMakeLists.txt', and
were installed in '/lib/CMakeLists.txt'. Consolidate them into
'/lib/SwiftSyntax/CMakeLists.txt'. Now the swift-syntax libraries look
like any other tool libraries outside the 'lib/SwiftSyntax', as they
should.
@rintaro rintaro requested review from bnbarham and etcwilde January 12, 2024 20:55
@rintaro
Copy link
Member Author

rintaro commented Jan 12, 2024

@swift-ci Please smoke test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, I like it!

@rintaro rintaro merged commit 677e971 into swiftlang:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants