[5.10][CodeCompletion] Fix issue in which parts of a result builder were incorrectly skipped #70899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
changed the title
ahoppen
changed the title
…correctly skipped
`getLoc` does not necesarrily return the start location of the location (e.g. for `a.b().c()` it returns the location of `c` because that’s the location of the call). But we used the location from `getLoc` as the start location of the synthesized `buildExpression` call. In the added test case, this means that the `buildExpression` call only contained `everlay() {}` and not the code completion token. We thus infered that we could skip it the entire `MyStack {}.pnTabGesture {}.everlay() {}` call for code completion, which isn’t correct.
rdar://120798355
ahoppen
force-pushed
the
ahoppen/5.10/rdar120798355
branch
from
ccdf222 to
e64ec00
Compare
|
@swift-ci Please test |
|
Original: #70898 |
airspeedswift
approved these changes
Jan 16, 2024
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLocdoes not necessarily return the start location of the location (e.g. fora.b().c()it returns the location ofcbecause that’s the location of the call). But we used the location fromgetLocas the start location of the synthesizedbuildExpressioncall. In the added test case, this means that thebuildExpressioncall only containedeverlay() {}and not the code completion token. We thus inferred that we could skip it the entireMyStack {}.pnTabGesture {}.everlay() {}call for code completion, which isn’t correct.buildExpression