Implement #isolation macro to produce the isolation of the current context
#70902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
ktoso,
kavon,
hborla,
xedin,
slavapestov,
ahoppen,
bnbarham,
CodaFi,
hamishknight,
rintaro and
tshortli
as code owners
|
@swift-ci please smoke test |
ktoso
approved these changes
Jan 13, 2024
hborla
reviewed
Jan 13, 2024
lib/Sema/CSSyntacticElement.cpp.rej
Outdated
| @@ -0,0 +1,11 @@ | |||
| @@ -1053,8 +1060,8 @@ | |||
There was a problem hiding this comment.
Did you mean to commit this file?
There was a problem hiding this comment.
Whoops, sorry. My local tree is a mess. This PR needs a bit of work still
…context Introduce a new expression macro that produces an value of type `(any AnyActor)?` that describes the current actor isolation. This isolation will be `nil` in non-isolated code, and refer to either the actor instance of shared global actor in other cases. This is currently behind the experimental feature flag OptionalIsolatedParameters.
DougGregor
force-pushed
the
isolation-macro
branch
from
b438e25 to
255009d
Compare
|
Already tested, and I only dropped the one file. Merging... |
finagolfin
reviewed
Jan 19, 2024
| /// isolated, or `nil` if the code is nonisolated. | ||
| @available(SwiftStdlib 5.1, *) | ||
| @freestanding(expression) | ||
| public macro isolation() -> (any AnyActor)? = Builtin.IsolationMacro |
There was a problem hiding this comment.
This just broke the Android community CI, which doesn't have a prebuilt host Swift compiler so the trunk compiler it builds doesn't use the swift-syntax parser and doesn't support macros:
swift/stdlib/public/Concurrency/Actor.swift:80:14: error: macros are not supported in this compiler
public macro isolation() -> (any AnyActor)? = Builtin.IsolationMacro
^
Other uses of macros in the stdlib have put in checks to avoid this problem, maybe something similar would work here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new expression macro that produces an value of type
(any AnyActor)?that describes the current actor isolation. This isolation will benilin non-isolated code, and refer to either the actor instance of shared global actor in other cases.This is currently behind the experimental feature flag OptionalIsolatedParameters.