[Distributed] Allow isolated any DistributedActor
#70906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
DougGregor
approved these changes
Jan 13, 2024
DougGregor
reviewed
Jan 13, 2024
| } | ||
|
|
||
| @main struct Main { | ||
| static func main() async { |
There was a problem hiding this comment.
Needs @available(SwiftStdlib 5.1, *) here, I think
This was mistakenly not allowed; the logic for hopping actors will just work, however we guarded the isolated being allowed only on "is actor" but it should have been checking for "is any actor"
ktoso
force-pushed
the
wip-existential-da-isolated
branch
from
f377ce4 to
dfce2aa
Compare
|
@swift-ci please smoke test |
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
carlos4242
pushed a commit
to carlos4242/swift
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mistakenly not allowed; the logic for hopping actors will just work, however we guarded the isolated being allowed only on "is actor" but it should have been checking for "is any actor"
resolves rdar://120938773