Check the base address against the element alignment rather than stride #70911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stride is the gap between elements, not the alignment that each element must satisfy (stride need not even be a power of two).
|
@swift-ci test |
glessard
approved these changes
Jan 14, 2024
glessard
reviewed
Jan 15, 2024
glessard
reviewed
Jan 15, 2024
glessard
approved these changes
Jan 15, 2024
|
@swift-ci please test |
|
Of all the little things about operator precedence in Swift, this is the one I dislike the most. |
it seems this would have failed on 32bit with strict alignment enforcement
glessard
force-pushed
the
check-alignment-not-stride
branch
from
59fd7ba to
67d41ac
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Also get 80c formatting on these calls.
|
@swift-ci smoke test |
|
(Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stride is the gap between elements, not the alignment that each element must satisfy (stride need not even be a power of two).