Sema: Suppress unavoidable deprecation diagnostics in _Concurrency #70912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _Concurrency module must use some deprecated declarations in its implementation in order to maintain backward compatibility. Since these references are unavoidable, the deprecation diagnostics emitted about them are an unhelpful nuisance. This change introduces targetted logic for suppressing these specific deprecation diagnostics as a workaround until there is a language feature for suppressing deprecation diagnostics.
tshortli
requested review from
ktoso,
kavon,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
ktoso
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _Concurrency module must use some deprecated declarations in its implementation in order to maintain backward compatibility. Since these references are unavoidable, the deprecation diagnostics emitted about them are an unhelpful nuisance. This change introduces targetted logic for suppressing these specific deprecation diagnostics as a workaround until there is a language feature for suppressing deprecation diagnostics.
Also, remove a couple of superfluous
trys.