Resolve more warnings #70943
Merged
Resolve more warnings #70943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the BSD and `__APPLE__` branches consistent and suppresses the following warning: ``` warning: pointer is missing a nullability type specifier ```
SwiftObject intentionally does not inherit from `NSObject`.
…ary. ASL is deprecated in macOS 10.12. It may be time to transition to os_log now that deployment targets have been raised to 10.12, but until that project starts these warnings are just pollution. Filed rdar://121066531 to track adoption of `os_log()` if appropriate.
ASL is deprecated in macOS 10.12. It may be time to transition to os_log now that deployment targets have been raised to 10.12, but until that project starts these warnings are just pollution. Filed rdar://121076739 to track adoption of `os_log()` if appropriate.
tshortli
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
hamishknight,
rintaro,
mikeash,
al45tair,
ktoso,
kavon,
a team,
CodaFi,
DougGregor and
artemcm
as code owners
|
@swift-ci please smoke test |
artemcm
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For explanations/justifications, see messages for individual commits.