Resolve warnings in the Concurrency runtime #70948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed with Konrad that this was copypasta.
The `swift_unreachable()` is currently statically unreachable but we'd like to leave it in place in case the control flow before it changes in the future.
|
@swift-ci please smoke test |
ktoso
reviewed
Jan 17, 2024
| executor.enqueue(ExecutorJob(context: unownedJob._context)) | ||
| } else { | ||
| executor.enqueue(unownedJob) | ||
| } |
There was a problem hiding this comment.
yep, that's safe -- thank you
ktoso
reviewed
Jan 17, 2024
| swift_unreachable("expected to early return from when handling offer of last task in group"); | ||
| #pragma clang diagnostic pop |
There was a problem hiding this comment.
Nice, thank you -- yeah it's better to keep this comitted in case the control flow would change and we wrongly allowed this to be entered
ktoso
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashes a few warnings in files under
stdlib/public/Concurrency/.