[CSStep] Add a nullptr check to IsDeclRefinementOfRequest::evaluate
#70956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface type of an archetype is not always represented by a `SubstitutableType`, it could be a `DependentMemberType` as well. The code in `IsDeclRefinementOfRequest::evaluate` already partially accounts for that by using `getAs` but the nullptr check is missing which means that the resulting substitution map is incorrect.
|
@swift-ci please test |
slavapestov
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface type of an archetype is not always represented by a
SubstitutableType, it could be aDependentMemberTypeas well.The code in
IsDeclRefinementOfRequest::evaluatealready partiallyaccounts for that by using
getAsbut the nullptr check is missingwhich means that the resulting substitution map is incorrect.