Skip to content

[IRGen][WMO] type descriptors generated for an imported Clang types a… #70977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jan 18, 2024

…re always known local declarations

This fixes a LNK4217 linker warning when building code on Windows

@hyp
Copy link
Contributor Author

hyp commented Jan 18, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jan 18, 2024

still working on tests

@hyp hyp force-pushed the eng/clang-nom-type-descr-local branch from 1d97c49 to b5d0032 Compare January 18, 2024 21:00
@hyp hyp marked this pull request as ready for review January 18, 2024 21:01
@hyp hyp requested review from compnerd and hjyamauchi January 18, 2024 21:02
@hyp hyp force-pushed the eng/clang-nom-type-descr-local branch from b5d0032 to 9491de4 Compare January 18, 2024 21:05
@hyp hyp force-pushed the eng/clang-nom-type-descr-local branch from 9491de4 to 21ab70e Compare January 19, 2024 01:01
@hyp
Copy link
Contributor Author

hyp commented Jan 19, 2024

@swift-ci please test

…re always known local declarations

This fixes a LNK4217 linker warning when building code on Windows
@hyp hyp force-pushed the eng/clang-nom-type-descr-local branch from 21ab70e to 57f3d23 Compare January 19, 2024 16:01
@hyp
Copy link
Contributor Author

hyp commented Jan 19, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jan 19, 2024

@swift-ci please test source compatibility

@hyp hyp merged commit ed7ed2d into swiftlang:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants