[AliasAnalysis] Improve builtin's effects to depend on escapingness. #70997
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
alias-analysis-builtin
branch
from
d19be45 to
7956ff2
Compare
|
@swift-ci please test |
eeckstein
reviewed
Jan 19, 2024
Mostly restore the behavior of getMemoryEffectsFn on builtins other than `once` and `onceWithContext` to before 8a8a895 but keeping the improvement to return `Instruction.memoryEffects` in the face of escaping.
nate-chandler
force-pushed
the
alias-analysis-builtin
branch
from
7956ff2 to
75ccbae
Compare
|
Added! |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly restore the behavior of getMemoryEffectsFn on builtins other than
onceandonceWithContextto before 8a8a895 but keeping the improvement to returnInstruction.memoryEffectsin the face of escaping.