Skip to content

[build] Install swift-format in all jobs that test sourcekit-lsp #71003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 19, 2024

With swiftlang/sourcekit-lsp#769, sourcekit-lsp supports formatting that invokes swift-format from the toolchain and tests that test this behavior. For those to pass, we need to install swift-format into the toolchain on all jobs that test sourcekit-lsp.

@ahoppen
Copy link
Member Author

ahoppen commented Jan 19, 2024

@swift-ci Please smoke test

With swiftlang/sourcekit-lsp#769, sourcekit-lsp supports formatting that invokes swift-format from the toolchain and tests that test this behavior. For those to pass, we need to install swift-format into the toolchain on all jobs that test sourcekit-lsp.
@ahoppen ahoppen force-pushed the ahoppen/install-swiftformat-for-lsp branch from 9c1bc85 to 7ec0fcf Compare January 19, 2024 06:03
@ahoppen
Copy link
Member Author

ahoppen commented Jan 19, 2024

@swift-ci Please smoke test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was just a find + add for anything that had sourcekit-lsp?

@ahoppen
Copy link
Member Author

ahoppen commented Jan 20, 2024

Yes

@ahoppen ahoppen merged commit 7b5fa6e into swiftlang:main Jan 20, 2024
@ahoppen ahoppen deleted the ahoppen/install-swiftformat-for-lsp branch January 20, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants