[oslog-overlay-fixes] 3.1 backport #7101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yout issues. Address a whole slew of issues that resulted in packing bad compiler-like structures that are passed to libtrace. Along with some fixes with the format string parsing, this fixes several major bugs when trying to use `os_log` from Swift. Addresses radars: <rdar://problem/28147363> [overlay] public and private per parameter settings do not work in Swift on device <rdar://problem/28908210> BLOCKED: Add support for ErrnoKind in Libtrace to support %m <rdar://problem/29121938> os_log with no variables gives "corrupted" <rdar://problem/28763393> Floating-point values logged via os_log from Swift are wrong when viewed in Console app <rdar://problem/28961322> `%s` produces no output
Adopt libtrace os_log_pack in order to more accurately provide logging data to libtrace. This allows the overlay code to supply the caller's pc to libtrace and fix `log show --source` to show the caller's source information when called from Swift. Addresses radar: <rdar://problem/29195869> os_log in Swift via overlay does not include 'source' filename/line number in `log stream`
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for oslog's overlay implementation that are already present in swift-4.0-branch that need to be backported to 3.1.