In Swift 3 mode, allow "tuple unsplatting" in certain cases. #7102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Jan 27, 2017
jrose-apple
commented
- Explanation: Swift 3.0 allowed constructing an enum or calling a function-typed property with multiple arguments even when a single argument of tuple type was expected. Emulate that in Swift 3 mode by wrapping in an extra level of parentheses when the situation comes up.
- Scope: Affects tuple arguments passed to single, non-tuple parameters that happen to be generic.
- Issue: rdar://problem/30171399
- Reviewed by: @slavapestov, @DougGregor
- Risk: Low. The limited scope means this won't affect many people at all.
- Testing: Added compiler regression tests.
…ng#7077) Swift 3.0 allowed constructing an enum or calling a function-typed property with multiple arguments even when a single argument of tuple type was expected. Emulate that in Swift 3 mode by wrapping in an extra level of parentheses when the situation comes up. Last vestiges of fallout from SE-0110. Hopefully last, anyway. A nice follow-up to this commit might be to /warn/ in Swift 3 mode when this happens. rdar://problem/30171399
|
@swift-ci Please test |
|
Build failed |
|
I think Erik's fixed this—the super.sil failure from earlier. @swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.