[5.10][Concurrency] Handle cases where a property initializer is subsumed by another property for IsolatedDefaultValues
.
#71034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonisolated
to implicit initializers when the initializer does not require actor isolation because all property types areSendable
withnonisolated
initializer expressions. This was done by looking at the properties and initial values from the memberwise initializer. However, property wrappers and init accessors can have an actor isolation that's different from the initializer expression that it subsumes. If the backing property wrapper initializer is global actor isolation but the wrapped value initializer is not, the compiler incorrectly appliednonisolated
to implicit initializers, and SILGen later errored because the property wrapper backing initializer was skipped due to mismatching isolation, e.g.To fix this, skip property initializers that are subsumed, e.g. by an init accessor or a backing property wrapper initializer, and always consider the subsuming initializer to determine whether an implicit initializer can be
nonisolated
.This change also lessens the source break of SE-0411 by still emitting member initializers in implicit constructors when the initializer violates actor isolation to preserve the behavior of existing code when concurrency diagnostics are downgraded to warnings in Swift 5 mode.
-strict-concurrency=complete
or-enable-upcoming-feature IsolatedDefaultValues
that uses global-actor-isolated property wrappers withSendable
,nonisolated
wrapped value expressions and implicit initializers.IsolatedDefaultValues
from an experimental feature to an upcoming feature. #70839 still applies for explicit initializers; the bug here was only with actor isolation inference for implicit initializers.main
PR.IsolatedDefaultValues
. #71033