[Importer] Preserve argument labels even for accessors. #7104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Jan 27, 2017
jrose-apple
commented
- Explanation: The AST verifier is unhappy when an accessor's imported name gets selector-split but its parameters don't have that recorded. Although we're not using this for anything today, it seems best to keep the two in sync. (This is a partial cherry-pick of [Importer] Preserve argument labels even for accessors. #7007, without changes to how the verifier works.)
- Scope: Affects imported properties with custom setter names that would be selector-split.
- Issue: rdar://problem/29889051
- Reviewed by: @DougGregor
- Risk: Low. We're not using this information for anything, it just affects the verifier.
- Testing: Added compiler regression tests, checked that the original project gets past this failure.
The AST verifier is unhappy when an accessor's imported name gets selector-split but its parameters don't have that recorded. Although we're not using this for anything today, it seems best to keep the two in sync. rdar://problem/29889051 (cherry picked from commit fdbc84f)
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.