Lifetime dependence utilities #71055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For AddressUtils and LifetimeDepenendenceUtils.
atrick
force-pushed
the
lifetime-dependence
branch
from
41c0cf6 to
2ef870a
Compare
atrick
requested review from
hborla,
slavapestov,
xedin and
eeckstein
as code owners
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci benchmark |
eeckstein
approved these changes
Jan 23, 2024
| /// | ||
| /// TODO: Integrate this with SIL verification to ensure completeness. | ||
| /// | ||
| /// TODO: Convert AddressDefUseWalker to conform to AddressUtils after |
There was a problem hiding this comment.
How would that work? The problem is that AddressDefUseWalker is passing a Path down the walk functions.
| // base is never a guaranteed phi. | ||
| guard let introducer = introducers.pop() else { return nil } | ||
| assert(introducers.isEmpty, | ||
| "guaranteed phis not allowed when diagnosing lifetime dependence") |
There was a problem hiding this comment.
Multiple introducers don't necessarily stem from phis. Think of the Pair example. Is this something to consider here?
| /// %base = struct_extract %parent // lifetime dependence base value | ||
| /// %dependent = mark_dependence [nonescaping] %value on %base | ||
| /// | ||
| /// This extends the ForwardingDefUseWalker, which finds the |
There was a problem hiding this comment.
ForwardingDefUseWalker -> ForwardingUseDefWalker
| /// end_borrow %5 | -+ | | ||
| /// destroy_value %4 -+ | | ||
| /// ... | | ||
| /// destroy_value %parent // end dependence scope -+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LifetimeDependence utilities