[cxx-interop] Treat std::string as an owned type after libc++ change
#71071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the libc++ modulemap was split into multiple top-level modules, the owning module of `class basic_string` changed: it is now `std_string` instead of `std`. That means `std.apinotes` is no longer picked up by clang, and `SwiftImportAs: owned` has no effect. This makes sure we continue treating `std::string` as an owned type, and import default expressions of `std::string` parameters properly. rdar://121391798
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Abandoning this in favor of #71181 and swiftlang/llvm-project#8063 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the libc++ modulemap was split into multiple top-level modules, the owning module of
class basic_stringchanged: it is nowstd_stringinstead ofstd. That meansstd.apinotesis no longer picked up by clang, andSwiftImportAs: ownedhas no effect.This makes sure we continue treating
std::stringas an owned type, and import default expressions ofstd::stringparameters properly.rdar://121391798