[embedded] Resolve ptrauth crashes by signing HeapObjects's isa pointers in embedded Swift #71076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers in embedded Swift
kubamracek
requested review from
phausler,
mikeash,
al45tair,
rauhul and
eeckstein
|
@swift-ci please test |
mikeash
approved these changes
Jan 23, 2024
Not without some larger refactoring: MetadataValues.h is a C++ header (and SpecialPointerAuthDiscriminators is a namespace), but this EmbeddedShims.h header is a C header (and needs to stay as C to be importable to Swift). I'll try to think about what can be done about this later. |
|
Makes sense. Not a big deal, it’s not like these numbers will ever change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual function calls verify isa signatures even in non-objc-interop mode on Embedded Swift, so we need to sign isa pointers in swift_allocObject and friends.
rdar://121398826