Skip to content

A couple of ReturnStmt tweaks #71094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2024
Merged

A couple of ReturnStmt tweaks #71094

merged 4 commits into from
Jan 24, 2024

Conversation

hamishknight
Copy link
Contributor

Introduce ReturnStmt::createParsed and ReturnStmt::createImplicit, and tweak a couple of other things.

@hamishknight
Mark a couple of ReturnStmts implicit
12af066 
These are both synthesized returns, so they ought
to be marked implicit.
@hamishknight
[AST] NFC: Add convenience constructors for ReturnStmt
c97d80b 
Add `ReturnStmt::createParsed` and `createImplict`.
@hamishknight
[AST] Improve FailStmt source location computation
246f09a 
Avoid forming invalid source ranges when
`ReturnLoc` is invalid. Also introduce a utility
to make this kind of range computation easier,
and use it in a couple of other cases.
@hamishknight
Unset the return location for an implicit return nil
71d8a9c 
The `return` keyword here doesn't have a source
location, so unset it. This matches the other
implicit single expression returns.
bnbarham
bnbarham approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup 🙇. Going to do BraceStmt too 😆?

@hamishknight
Copy link
Contributor Author

swiftlang/llvm-project#8027

@swift-ci please test

@hamishknight hamishknight mentioned this pull request Jan 23, 2024
Merged
@hamishknight
Copy link
Contributor Author

hamishknight commented Jan 23, 2024 •
edited
Loading

Going to do BraceStmt too 😆?

Heh, we actually have BraceStmt::createImplicit already, just need to go through and migrate everything passing /*implicit*/ true to BraceStmt::create 😅

@hamishknight hamishknight merged commit 3a8e31d into swiftlang:main Jan 24, 2024
@hamishknight hamishknight deleted the return-tweaks branch January 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@bnbarham bnbarham bnbarham approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@ahoppen ahoppen Awaiting requested review from ahoppen

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamishknight @ktoso @bnbarham