[SILGen] Ensure that we emit the distributed-actor-as-actor conformance #71105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distributed-actor-as-actor conformance is synthesized by the frontend, so make sure that when we access the API that exposes it (asLocalActor), we be sure to mark the conformance as "used". This is a very specific workaround for general problem with compiler-synthesized conformances. SIL deserialization can bring in a reference to a conformance late in the SIL pipeline, after the point at which SILGen can create the conformance. We should be able to address this systemically to remove the hack.
DougGregor
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
ktoso
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed-actor-as-actor conformance is synthesized by the frontend, so make sure that when we access the API that exposes it (asLocalActor), we be sure to mark the conformance as "used".
This is a very specific workaround for general problem with compiler-synthesized conformances. SIL deserialization can bring in a reference to a conformance late in the SIL pipeline, after the point at which SILGen can create the conformance. We should be able to address this systemically to remove the hack.